Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sitemap): use pages to build the sitemap #7040

Closed
wants to merge 1 commit into from

Conversation

ematipico
Copy link
Member

Changes

Closes #7015

When in SSG, we read the pages files, which contain all the paths that were generated. In SSR, we keep using the routes property. In SSR pages is empty.

Testing

Added a new case and made sure there were no regressions.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: c4ed905

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 8, 2023
@ematipico ematipico force-pushed the fix/sitemap-content branch from 5586c30 to c4ed905 Compare May 8, 2023 17:20
@ematipico ematipico closed this May 8, 2023
@ematipico ematipico deleted the fix/sitemap-content branch July 18, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astrojs/sitemap 1.3.0 no longer builds dynamic routes into sitemap
2 participants