-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(overlay): Add a settings panel #9058
Conversation
🦋 Changeset detectedLatest commit: bacda87 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚖️ Bundle Size CheckLatest commit: bacda87
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'd need a changeset before merging this.
I have a few thoughts about the design/behaviour, but not blocking the PR:
- When opening the first Astro panel, then the settings panel, should the Astro panel auto-close? So there's only one panel at a time.
- The settings name e.g.
Verbose logging?
feels a bit weird with the?
. I don't usually see trailing punctuations in settings names. - Each setting controls, the setting description is larger than the setting title. Is it intentional?
EDIT: The above image is what I see locally in Safari and Chrome, which seems to be slightly different compared to your screenshot.
Strange, I can't reproduce this anymore. Sorry for the false alarm 😅 |
Changes
Add a little settings panel guy and the components it needs (the toggle)
Those options are saved locally, using
localStorage
and are intended for Dev Overlay settings.Testing
Added a test that it opens and closes, like other plugins
Docs
Will do docs