feat(dev-overlay): Hide plugins into a separate menu when there's too many enabled #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6878f89 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
⚖️ Bundle Size CheckLatest commit: 6878f89
|
Princesseuh
commented
Nov 14, 2023
| @@ -20,6 +23,7 @@ export class AstroDevOverlay extends HTMLElement { | |||
| plugins: DevOverlayPlugin[] = []; | |||
| HOVER_DELAY = 750; | |||
| hasBeenInitialized = false; | |||
| customPluginsToShow = 3; | |||
There was a problem hiding this comment.
Currently, this is hardcoded. In the future, we plan to make it so it depends on the width of your screen. Unfortunately, this requires quite some refactoring in how the dev overlay UI is built to ensure compatibility with view transitions and stuff, so will tackle it later.
github-actions
bot
added
the
pr: docs
matthewp
approved these changes
Nov 15, 2023
bluwy
approved these changes
Nov 15, 2023
peng
added a commit
to peng/astro
that referenced
this pull request
Nov 17, 2023
* main: feat(i18n): add `Astro.currentLocale` (withastro#9101) [ci] release (withastro#9107) Add compatibility with cloudflare node (withastro#8925) [ci] format Cancel response stream when connection closes (withastro#9071) [ci] format feat(i18n): apply specific routing logic only to pages (withastro#9091) feat(dev-overlay): Hide plugins into a separate menu when there's too many enabled (withastro#9102) [ci] format Support Svelte 5 (experimental) (withastro#9098) [ci] release (withastro#9078) [ci] format Refactor shikiji syntax highlighting code (withastro#9083) [ci] format fix: Query params trigger the trailingSlash error in preview mode (withastro#9045) fix(assets): bundling regression for specific config on non-Node runtimes (withastro#9087)
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a new little guy menu when the user has too many plugins in order to not overcrowd the bar
When any of the plugins in it have a notification, it'll show on the three dots, like so:
Testing
Tested manually for now, will be tested in a different PR
Docs
N/A, plugins don't have anything to do, all the APIs work the same.