Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for alternative markdown file extensions #1893

Merged
merged 13 commits into from
Oct 27, 2022
Merged

add docs for alternative markdown file extensions #1893

merged 13 commits into from
Oct 27, 2022

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Oct 23, 2022 •
edited
Loading

What kind of changes does this PR include?

  • New or updated content

Description

Adds .markdown and alternatives as a possible file extension for markdown files

@netlify
Copy link

netlify bot commented Oct 23, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 57c6a67
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/635a8f9dfa34a9000841294c
😎 Deploy Preview https://deploy-preview-1893--astro-docs-2.netlify.app/de/guides/content
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest labels Oct 24, 2022
@sarah11918
Copy link
Member

Looking good, @MoustaphaDev! Just this morning I noticed we will also need a few similar changes on /en/guides/content, so it would be great if you could include that page here as well! 🥳

@MoustaphaDev MoustaphaDev mentioned this pull request Oct 24, 2022
Merged
@MoustaphaDev MoustaphaDev changed the title add .markdown as a possible extension for markdown files [🚧WIP] add docs for alternative markdown file extensions Oct 24, 2022
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Oct 26, 2022
@sarah11918 sarah11918 marked this pull request as ready for review October 26, 2022 17:34
@sarah11918
Copy link
Member

Sorry! Had a total reversal and just updated everything now! Can you please look over all my suggested changes, apply them if they're good, and then no need for a follow up? @MoustaphaDev

MoustaphaDev and others added 8 commits October 27, 2022 13:50
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
73a229d 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
9f4b7a1 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
ea836e1 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
c7ef542 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
113dc0e 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
b363c61 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/markdown-content.md
0abda60 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev @sarah11918
Update src/pages/en/guides/content.md
e03ee53 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@MoustaphaDev
Copy link
Member Author

Sorry! Had a total reversal and just updated everything now! Can you please look over all my suggested changes, apply them if they're good, and then no need for a follow up? @MoustaphaDev

Thanks for the amazing reviews ❤️! I think it's ready to be merged

@sarah11918
Copy link
Member

Yup, I think we did it! Just waiting for the branch to update and checks to pass!! 🥳 Thanks for being so responsive!

@MoustaphaDev MoustaphaDev changed the title [🚧WIP] add docs for alternative markdown file extensions add docs for alternative markdown file extensions Oct 27, 2022
@sarah11918 sarah11918 merged commit 49875af into withastro:main Oct 27, 2022
@MoustaphaDev MoustaphaDev deleted the update-markdowncontent-page branch October 27, 2022 14:10
@fredoist fredoist mentioned this pull request Oct 28, 2022
Merged
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoustaphaDev @sarah11918