🐛 BUG: astro check summary shows warnings as hints

[florian-lefebvre]

Describe the Bug

When running astro check with warnings, the summary shows the same number as hints

Steps to Reproduce

1. Get a warning and run astro check

(Don't use this reproduction as an example okay? Very bad)

[Princesseuh]

Not 100% sure if this is a printing or collecting issue, but:

The printing happens here:

language-tools/packages/astro-check/src/index.ts

Lines 79 to 94 in 4ca26c0

	console.info(
	[
	bold(`Result (${result.fileChecked} file${result.fileChecked === 1 ? '' : 's'}): `),
	['error', 'warning', 'hint'].includes(minimumSeverity)
	? bold(red(`${result.errors} ${result.errors === 1 ? 'error' : 'errors'}`))
	: undefined,
	['warning', 'hint'].includes(minimumSeverity)
	? bold(yellow(`${result.warnings} ${result.warnings === 1 ? 'warning' : 'warnings'}`))
	: undefined,
	['hint'].includes(minimumSeverity)
	? dim(`${result.hints} ${result.hints === 1 ? 'hint' : 'hints'}\n`)
	: undefined,
	]
	.filter(Boolean)
	.join(`\n${dim('-')} `)
	);

and the collecting happens here:

language-tools/packages/language-server/src/check.ts

Lines 117 to 125 in 4ca26c0

	result.errors += fileDiagnostics.filter(
	(diag) => diag.severity === DiagnosticSeverity.Error
	).length;
	result.warnings += fileDiagnostics.filter(
	(diag) => diag.severity === DiagnosticSeverity.Warning
	).length;
	result.hints += fileDiagnostics.filter(
	(diag) => diag.severity === DiagnosticSeverity.Hint
	).length;

Both seems correct to me at first glance, so not 100% sure where the issue is. Something to note is that TypeScript has a weird relationship with diagnostic severity, so that might be related too.

[Princesseuh]

It's also possible for this mistake to be in Volar itself, see: https://github.com/volarjs/volar.js/blob/ea2e22ca17116b4274d661a014cff040c1d206cb/packages/kit/lib/createChecker.ts#L230

My recommendation here would be to match tsc.

[fsmeier]

+1

Any news on the issue? Seems like astro check is not that much usable with that. :/

I also tested astro check --minimumFailingSeverity hint --minimumSeverity hint but it seems to just continue.

[Princesseuh]

I'm not sure I understand how this affects astro check's usability, this is mainly visual

[fsmeier]

I think it is not just visual - with the option --minimumFailingSeverity warning or --minimumFailingSeverity hint it should have failed, but it did not in both cases. just with error (when i placed one)

[fsmeier]

Hmm, maybe this is also a clue we could follow:

In the github action the option --minimumFailingSeverity warning seems to work and does not show the hints which are labeled "warning". Locally it will show them anyway.
In the ci i use ubuntu-latest. Locally I use node:20 which should be based on debian.