-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numeric functions shouldn't return NaN #539
Comments
But the question becomes then, how does Eve allow the detection of out of range function use? Or equally, how does Eve handle divide by zero? At the moment, whatever the result that comes out of Javascript is republished. This I agree is probably an issue. But I am unsure whether filtering the result is the correct form. |
I got curious so had a play. This push This code now would not run search But this code runs correctly search So code written carelessly in terms of a divisor or testing for NaN is more than likely going to filter, but still leaving the possibility open of a more nuanced examination if necessary. //Edit. Don't use the above commit. It causes issues for other uses of operators. |
This has been in since 0.2.2, thanks again! |
A function that would return NaN should instead return no results.
The text was updated successfully, but these errors were encountered: