Better messages for Eve server #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibdknox
reviewed
Nov 15, 2016
| // If the port is already in use, display an error message | ||
| process.on('uncaughtException', function(err) { | ||
| if(err.errno === 'EADDRINUSE') { | ||
| console.log(`ERROR: Eve couldn't start because port ${PORT} is already in use. Close the process using this port and try again.`); |
There was a problem hiding this comment.
Instead of telling them to close the thing on that port, we could tell them to use the PORT env variable to use a different port.
ibdknox
approved these changes
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays a better message when the server stops, and a better error when the server cannot start due to the port being in use.