Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when JSON value is null #593

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Fix error when JSON value is null #593

merged 1 commit into from
Nov 28, 2016

Conversation

cgarvis
Copy link
Contributor

@cgarvis cgarvis commented Nov 22, 2016

No description provided.

@cmontella
Copy link
Contributor

Fixes: #478

@xymostech
Copy link

As mentioned in #478, this would mean that the null value doesn't get recorded in the record at all, so de-serializing then serializing again might lose keys. I would love this merged though because it's painful not being able to use APIs that have nulls in the responses.

@ibdknox
Copy link
Contributor

ibdknox commented Nov 28, 2016

Yeah, there's a follow up PR that needs to happen after this one that adds the sentinel value for json nulls.

@ibdknox
Copy link
Contributor

ibdknox commented Nov 28, 2016

Thanks!

@ibdknox ibdknox merged commit bb0ce75 into witheve:master Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants