Fixed cursor reset when changing value of input. #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Whenever changing an input's value, the cursor is reset to the end of the input. Not noticable unless you try to change something in an input value that is not at the end.
How to reproduce
With the following Eve program:
Fill in the input with a string. Move the cursor to the beginning of the string (or anywhere not at the end). Write something. You'll see that it's impossible to add something without the cursor resetting to the end of the string.
Solution
The solution is actually very simple, and hinted at in
renderer.ts
, simply use setAttribute instead of setting the input value directly.