Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAX_ROUNDS 30 => 300 #623

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

frankier
Copy link

@frankier frankier commented Dec 1, 2016

This is necessary to make my Minesweeper example work for larger sizes. In the current version mine placement takes n*mines rounds to coalesce where n is some small factor n=1..3. I don't know if there's the possibility of a more principled or better approach for this longer term (eg maybe this could be configurable somehow and the default could be 30) but I think a larger value might be good to tide things over until this is decided on.

Copy link
Contributor

@ibdknox ibdknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's fine to raise this for now. The main thing that MAX_ROUNDS is there for is to handle the case where you loop infinitely - we want there to be some way to notify you that it happened and then bail out. There's a more complex mechanism we could use to do that (e.g. hash each timestep's state and if you encounter the same hash again you know you're looping), but that requires a lot of effort to implement.

@ibdknox ibdknox merged commit bbcf652 into witheve:master Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants