Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in "gaussian" function #641

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Fix a bug in "gaussian" function #641

merged 2 commits into from
Dec 5, 2016

Conversation

pithub
Copy link
Contributor

@pithub pithub commented Dec 4, 2016

The Gaussian provider uses different keys when reading and writing into the internal cache, so it violates referential transparency as describe here: https://gist.github.com/joshuafcole/52f706e0e838b3fb7536814de8879af0.

When reading the cache, use the same key as for writing into the cache.
@cmontella cmontella self-assigned this Dec 5, 2016
@cmontella
Copy link
Contributor

Thanks for spotting this!

@joshuafcole joshuafcole merged commit a3bf021 into witheve:master Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants