Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fix function. #665

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Add Fix function. #665

merged 1 commit into from
Dec 7, 2016

Conversation

Cormac-Williams
Copy link
Contributor

Mentioned as missing in witheve/docs#46

@cmontella cmontella self-assigned this Dec 7, 2016
@cmontella
Copy link
Contributor

Thanks for this! The reason I wrote the doc in the first place was because I was copying off of some matlab docs, and that's the one I happened to have opened. Hopefully this is just what someone was looking for :)

@Cormac-Williams
Copy link
Contributor Author

You're welcome. I should have noted that this is a re-implementation of the Trunc function from Javascripts Math. I didn't catch cos I thought it was already done. So I have kept the naming in line with the docs. It may be a confusion to newcomers who recognise the naming of all the other functions to keep the name as is, but obviously it's more work to change both. Let me know if you guys want to re-name and I'll help out.

Regards,
Cormac.

@cmontella
Copy link
Contributor

Looks good, thanks, we'll keep it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants