Fix DependencyChecker if branch that looks at attributes with a fixed value #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuafcole
reviewed
Dec 8, 2016
| @@ -120,7 +120,7 @@ export class DependencyChecker { | |||
| if(deps["any"]) { | |||
| let attr = deps["any"][a]; | |||
| if(attr === true) return true; | |||
| if(attr === true && attr[v] === true) return true | |||
| if(attr && attr[v] === true) return true | |||
joshuafcole
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very strange symptoms are caused by this mistake which would prevent some blocks from running even when changes should've made them do so. Any block that looked for an attribute with a fixed value on a record with no tags would be skipped since
attrcannot be bothtrueand an object at the same time :(