-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/save load gist #675
Conversation
…igator for loaded documents
Is this able to load regular github links yet? |
Seems to work fine for gists :) I think we probably want to make some changes here to make it a little more obvious UX-wise:
|
//console.error("Cannot load non-existent document."); | ||
//return; | ||
|
||
root = this.nodes[id] = {id, type: "document", name}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always right? What happens if I do try to load something non-existent locally?
{c: `${this.open ? "expand-btn" : "collapse-btn"} ion-ios-arrow-back`, click: this.togglePane}, | ||
|
||
this.open && type === "document" ? {c: "ion-ios-cloud-upload-outline btn", title: "Save to Gist", click: () => this.ide.saveToGist()} : undefined, | ||
this.open && type === "document" ? {c: "ion-ios-cloud-download-outline btn", title: "Load from Gist", click: this.openLoadDialog} : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like I should be able to load a gist regardless of where I am
@ibdknox thoughts on making the saved notice more visible without being obnoxious? |
Nav is empty when:
On change the new file doesn't show up in the directory index without a refresh. |
This is ready to ship pending final approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Enables
Blocking tasks:
Notes: