Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many concatenated relationships on line #53

Open
SamLoy opened this issue Apr 4, 2017 · 2 comments
Open

Too many concatenated relationships on line #53

SamLoy opened this issue Apr 4, 2017 · 2 comments

Comments

@SamLoy
Copy link

SamLoy commented Apr 4, 2017

I'm using ml-lodlive over a very large dataset. Some of the entities have multiple (100s) relationships between them.
For example:

  • Sam is Bananas
  • Sam went Bananas
  • Sam ate Bananas
  • Sam dislikes Bananas

On my large dataset the label on the line between the two node circles can look crazy since it is rendering every single relationship.

I've forked the repo here with a candidate fix. It provides a new UI.maxRelationshipsToRender flag which when exceeded renders ' and N more' on the label.

For example, on the line between Sam and Bananas it would render "is, went and 2 more".

Let me know if you want me to raise a PR.

@joemfb
Copy link
Contributor

joemfb commented Apr 4, 2017

This looks good! It was definitely an oversight on my part -- I'd like to see a PR. @withjam?

@SamLoy
Copy link
Author

SamLoy commented Apr 5, 2017

#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants