Really Fixes #368: Mocha 4.0.x: Test process never finishes. Cleaning…

… up Detox server by closing ws socket. :P
wix · Nov 12, 2017 · 7b10cab · 7b10cab
1 parent 6f8f9b8
commit 7b10cab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/detox-server/src/DetoxServer.js b/detox-server/src/DetoxServer.js
@@ -68,6 +68,10 @@ class DetoxServer {
       log.log('wss', `${now()}:`, `role=${otherRole} not connected, cannot fw action (sessionId=${sessionId})`);
     }
   }
+
+  close() {
+    this.wss.close();
+  }
 }
 
 function now() {

diff --git a/detox/src/Detox.js b/detox/src/Detox.js
@@ -80,6 +80,10 @@ class Detox {
       await this.device._cleanup();
     }
 
+    if (this.server) {
+      this.server.close();
+    }
+
     if (argparse.getArgValue('cleanup') && this.device) {
       await this.device.shutdown();
     }
@@ -88,7 +92,7 @@ class Detox {
   async beforeEach(...testNameComponents) {
     this._currentTestNumber++;
     if (this._artifactsPathsProvider !== undefined) {
-      const testArtifactsPath = this._artifactsPathsProvider.createPathForTest(this._currentTestNumber, ...testNameComponents)
+      const testArtifactsPath = this._artifactsPathsProvider.createPathForTest(this._currentTestNumber, ...testNameComponents);
       this.device.setArtifactsDestination(testArtifactsPath);
     }
   }