Add prettier to detox folder

[AlanFoster]

This is the first PR to help deliver #223

This Pr adds support for prettier as part of detox's linting pipeline. In the future you can automagically fix errors with:

npm run lint -- --fix

In a separate PR I will add support for connecting this up to the CI pipeline, and husky for pre-push validations 👍

[AlanFoster]

cc @DanielMSchmidt / @rotemmiz

[DanielMSchmidt]

Could you maybe add a config to set spaces to tabs? That would be awesome!

[isnifer]

@AlanFoster Nice work. Awesome!

[DanielMSchmidt]

And having the prettierrc on root level would be pretty awesome 👍

[rotemmiz]

There are two big PRs adjacent to this PR (#268, #277) , please let's make them land in master before this PR, since there may be some ugly conflicts when merging.

If you can, it will be best if you could split the configuration of prettier from the actual code changes its linter generated, that way we could merge the config right, in and won't need to wait.

[AlanFoster]

@rotemmiz Sounds good to me 👍

As a quick question - would you prefer tabs or spaces? Or should we just stick to the default settings?

[DanielMSchmidt]

Tabs please, as discussed in #223. For the rest I would stick with the defaults :)

[AlanFoster]

@rotemmiz / @DanielMSchmidt I've dropped the commit that actually does the prettier transform. For now this is a configuration only PR as requested.

I have also dropped any rules that directly conflict with prettier, and I have decided to not progress with a .prettier file - in favour of keeping it within the eslintrc file:

    "prettier/prettier": [
      "error", {
        "useTabs": true
      }
    ],

Once the blocking PRs are merged in, I can put up another PR that has run npm run lint -- --fix and send future PRs which update the CI pipeline etc 👍

Let me know if there are any other changes to be made :)

[rotemmiz]

Hey @AlanFoster , can you please update the branch and resolve conflicts, I want to merge this PR after CI is green.

Thanks!

[rotemmiz]

Hey @AlanFoster , can you please update the branch and resolve conflicts, I want to merge this PR after CI is green.

Thanks!

[AlanFoster]

@rotemmiz Thanks for the poke; Rebased as requested 👍

I can put up further PRs to fix the linting issues, or you can run npm run lint -- --fix directly yourself too, just let me know what you'd want like :)

[DanielMSchmidt]

@AlanFoster Can you take a look at #432? I redid the changes you introduced, this PR is somehow not rebaseable...

[AlanFoster]

@DanielMSchmidt For visibility the this PR is rebased and should be good to go still :)

[DanielMSchmidt]

Awersome, thanks @AlanFoster 👍