Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-entrypoint code is cryptic #911

Open
RomanYarik opened this issue Aug 24, 2021 · 0 comments
Open

create-entrypoint code is cryptic #911

RomanYarik opened this issue Aug 24, 2021 · 0 comments
Assignees
@thehulke
Labels
good first issue Good for newcomers

Comments

@RomanYarik
Copy link
Contributor

the entire code of generating a web entrypoint (create-entrypoint.ts in engine-scripts) is a combination of template strings.

This makes this peace of code to be very prone to errors and bugs, and makes this code non testable.

We should refactor this file to be as typed as possible and the code of the entrypoint itself to be very lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehulke thehulke

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thehulke @RomanYarik