New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Refinement #47

Open

marcos-wz opened this issue Apr 27, 2024 · 0 comments

Labels

Collaborator

marcos-wz commented Apr 27, 2024 •

edited

Loading

In the initial version, we only got a basic and functional version of the service, so it is necessary to refine all its components.

To be refined:

Validate active user is set to TRUE on responses(include test cases)
Implement DTO UserResponse in the Find function.
Testing
Handling error. Remember to configure the specific response in the controller error handler.
Naming conventions
Remove boilerplate code
Performance
Best practices

Issues to be fixed:

Deleting a not existent user returns true
It's not able to authenticate the user due to always returns invalid password error.

marcos-wz added dev refinement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment