Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation on OpenBSD/amd64 #141

Closed
leonstafford opened this issue Jan 11, 2020 · 9 comments
Closed

Support installation on OpenBSD/amd64 #141

leonstafford opened this issue Jan 11, 2020 · 9 comments
Labels

Comments

@leonstafford
Copy link

Unable to install on OpenBSD

Add support for installation on OpenBSD, doas v sudo, ksh over bash

Haven't looked into what is required for PR yet

@wjdp
Copy link
Owner

wjdp commented Jan 11, 2020

I have zero experience with BSD, would appreciate some help here.

@leonstafford
Copy link
Author

@wjdp happy to help! Wanted to get the feature request in at least. I have zero experience with Go, but should be able to do some prep/maybe a PR.

Thinking out loud:

  • see what errors occur when the platform check is removed
  • check for sudo calls, see how other projects have added doas support
  • check for bash usage, see if it can change to sh or detect/switch if no bash, but have ksh
  • see if there's a way to add OpenBSD tests to current CI

@leonstafford
Copy link
Author

Checking out source allows it to build and execute fine for me on -current version of OpenBSD.

So, will check what can be done to the docs / public install script currently failing

@leonstafford
Copy link
Author

public install script generated by https://github.com/goreleaser/godownloader, no longer actively maintained, but has some activity in repo.

If contributing upstream to godownloader doesn't make sense, can look to patch current generated installer script to support OpenBSD

Caddy installer script for reference supporting OpenBSD

@leonstafford
Copy link
Author

alternatively, add notes in docs for installation on OpenBSD:

  • build from source (just go dependency)
  • alternative copy pasta install command using ftp
  • go get possible?

@leonstafford
Copy link
Author

may also be able to adjust goreleaser usage to build release for OpenBSD, similar to recommended install steps for Windows

@wjdp
Copy link
Owner

wjdp commented Jan 15, 2020

Have merged the MR but not on a machine where I can tag a new release today. Should be able to soon.

@wjdp
Copy link
Owner

wjdp commented Jan 25, 2020

Hi @leonstafford. Release is done, can you pull one of the binaries and check it works on your machine?

https://github.com/wjdp/htmltest/releases/tag/v0.12.1

@leonstafford
Copy link
Author

@wjdp many thanks! Working well here (amd64) 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants