Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #13

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix typo #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions alidns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,10 @@ func (s *AliSolver) loadSecretData(selector cmmeta.SecretKeySelector, ns string)
func (s *AliSolver) validSecretData(data []byte) bool {
for _, b := range data {
if b <= ' ' || b == 0x7f || b == '\t' {
return true
return false
}
}
return false
return true
}

// AliDNS is a client for manipulating Aliyun-DNS
Expand Down
2 changes: 1 addition & 1 deletion config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
// resource and fetch these credentials using a Kubernetes clientset.
type Config struct {
Region string `json:"region"` // optional
AccessKeyIdRef cmmeta.SecretKeySelector `json:"testAccessKeyIdRef"`
AccessKeyIdRef cmmeta.SecretKeySelector `json:"accessKeyIdRef"`
// AccessKeySecretRef will serve as the alias name for SecretAccessKeyRef
AccessKeySecretRef cmmeta.SecretKeySelector `json:"accessKeySecretRef"`
SecretAccessKeyRef cmmeta.SecretKeySelector `json:"secretAccessKeyRef"`
Expand Down