Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Matrix Setup Not Saving After 19 panels. #3295

Open
1 task done
bigsandman69 opened this issue Jul 20, 2023 · 13 comments
Open
1 task done

2D Matrix Setup Not Saving After 19 panels. #3295

bigsandman69 opened this issue Jul 20, 2023 · 13 comments
Labels
backburner low priority compared to other issues bug external Not part of WLED itself - an external plugin/remote etc.

Comments

@bigsandman69
Copy link

What happened?

I recently updated to the newest version of WLED beta release 0.14.0-b3. I am trying to use the 2D matrix setup for 24 8x32 led matrix panels. It will allow me to setup the 24 screens but when I hit save and go back into 2D configuration it will not save any past 19.

To Reproduce Bug

Add 24 matrix panels configure and save. Then go back into 2D configuration and will only show 19 panels configured and number 20 will be default and shows none past 20 in config windows at bottom.

Expected Behavior

2D configuration will not save any matrix panels past 19.

Install Method

Binary from WLED.me

What version of WLED?

WLED version 0.14.0-b3 (build 2306210)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Aircoookie
Copy link
Member

Are your panels on one LED pin or split across multiple? You are trying to drive 6.144 LEDs which is quite a huge amount even for an ESP32. Maximum LEDs per bus (pin) currently defaults to 2048, so you'll need to split your matrix across three pins.
Are you already able to drive all LEDs in 1D mode and just the 2D setup is giving you trouble?

@bigsandman69
Copy link
Author

Are your panels on one LED pin or split across multiple? You are trying to drive 6.144 LEDs which is quite a huge amount even for an ESP32. Maximum LEDs per bus (pin) currently defaults to 2048, so you'll need to split your matrix across three pins. Are you already able to drive all LEDs in 1D mode and just the 2D setup is giving you trouble?

Sorry I didn't put my hardware in description. I'm currently using Wasatch Advanced 8 channel controller board & Each channel controls 768 Leds of the overall panel. I updated it from WLED 0.13.3 to use the 2D configuration to give me options to display text when my show isn't running. Currently The board drives Matrix fine from XLights & It actually drives fine in WLED it just doesn't save the configuration after panel 19 in the 2D configuration page. when you go back into 2D configuration panel 19 is in default position and no panels past 19 show unless you make a change to number of panels and re-setup every panel past 19 again, but every time you leave the 2D configuration page it goes back to 19. Is there some sort of MAX set somewhere that would cause this not to save past 20 panels total?

@blazoncek
Copy link
Collaborator

Please post your cfg.json after saving 2D configuration.
You can obtain it from security settings page.

@dosipod
Copy link
Contributor

dosipod commented Jul 29, 2023

Seems to be pushing it , the 2D page even got reset when we added 24 panels but segments still showed the matrix . Prior to the reset as the OP mentioned you will only be able to save until panel 19 .Sorry to butt in
image
2D_RESET_AFTER_ADDING_24_PANELS.cfg.json.txt

@dosipod
Copy link
Contributor

dosipod commented Jul 29, 2023

A work around for the 2D page might be to just setup the whole thing as one matrix
image

However peek is broken and i am sure real leds will also not work correctly as I think we seen issue with even less leds here in discord https://discord.com/channels/473448917040758787/801531333067014164/1128562990338285628 , it was unfortunately not solved

onepanel_cfg.json.txt

@blazoncek
Copy link
Collaborator

2D_RESET_AFTER_ADDING_24_PANELS.cfg.json.txt

cfg.json looks ok and has 24 panels, 8 LED outputs 768 pixels each. I would guess RAM gets depleted somewhere.
Please use a debug build and provide debug output to narrow down this issue.

However peek is broken

Peek will not work correctly with anything above 4096 pixels. It is not designed for that.

@dosipod
Copy link
Contributor

dosipod commented Jul 30, 2023

Not sure my debug is helpful as I have no leds or if the setup with one panel is working for the OP . Still using debug build i could not see anything unusual on serial and i could add more panels but trouble start when the offset can no longer be changed . It might help if the last panels after 19 is added one by one ( meaning add one and save )
muti-panels-2d-page
image

@blazoncek
Copy link
Collaborator

I think the problem is that URL becomes too long. There is nothing we can do about it unless we reprogram web server.
The limit will be 21 panels in this case.

@blazoncek blazoncek added the external Not part of WLED itself - an external plugin/remote etc. label Jul 31, 2023
@blazoncek
Copy link
Collaborator

I am not sure we will be able to overcome this problem.
I will assign a backburner status and we'll see what we can do about it in the future.

@blazoncek blazoncek added the backburner low priority compared to other issues label Aug 9, 2023
@softhack007 softhack007 added this to the 0.15.0 candidate milestone Oct 1, 2023
@netmindz netmindz removed this from the 0.15.0-final candidate milestone Nov 26, 2024
@dosipod
Copy link
Contributor

dosipod commented Dec 16, 2024

I do not have that many to test but at least the limit in ui can be changed WLED_MAX_PANELS , strange it is in FX.h but someone in discord was trying that
image
image

@blazoncek
Copy link
Collaborator

blazoncek commented Dec 16, 2024

@dosipod unfortunately this change alone will not allow UI to behave save correctly.
It will allow, however, to modify cfg.json manually and for such change to take effect on reboot.

@dosipod
Copy link
Contributor

dosipod commented Dec 16, 2024

@blazoncek It is unfortunate that the person with the panels no longer interested in the code change to test but in my test unit with only WLED_MAX_PANELS changed I could still see the 2D page with 28 panels after the reboot .
I will see if someone has that many to do the full test with fixtures else ( which I hoped to avoid ) I will try to setup something with DDP .

Editing cfg.json which I hope is not needed is very dirty with that many panels as you would need to adjust the panels x and y position which I tried to do before we know about the WLED_MAX_PANELS in FX.h ,

@blazoncek
Copy link
Collaborator

@dosipod this issue was opened for this particular reason - not able to save panels beyond 19. Since then I intentionally limited panel number in code and UI to 18 (as 19 was unreliable). Previous value was 64.
The problem is in AWS handling of large POST request. Unrelated to WLED.
If changes made by @willmmiles improved AWS handling of large POST requests then the limit may be safely increased. How much, that will depend on buffer size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner low priority compared to other issues bug external Not part of WLED itself - an external plugin/remote etc.
Projects
None yet
Development

No branches or pull requests

6 participants