Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Updating Files Does not Cause HMR Reload #224

Closed
mchenryc opened this issue Jan 14, 2018 · 5 comments
Closed

Updating Files Does not Cause HMR Reload #224

mchenryc opened this issue Jan 14, 2018 · 5 comments

Comments

@mchenryc
Copy link

mchenryc commented Jan 14, 2018

I encountered facebook/create-react-app#659 (bug has same title), which has multiple known causes. The cause in my case was not listed, but has already been fixed upstream.

The issue was that my app was nested beneath the folder named* $monorepo/packages/node_modules, and ignored by webpack-dev-server's watch, due to an overeager regex for watchOptions.ignored.

This has already been fixed in CRA and master (1e98d0f, 36cd35d), but is not yet in the releasedreact-scripts-ts.

This issue should be closed by the next release. Perhaps this will help others.

* I'm using the "Alle" monorepo model, similar to Lerna, adopted by PouchDB

@mchenryc
Copy link
Author

Correction, this has not yet been fixed upstream. I'm not yet sure why I saw the watch being triggered when using that patch - it may relate to webpack/webpack-dev-server#1208, though would not explain sporadic success.

@wmonk
Copy link
Owner

wmonk commented Jan 15, 2018

Ok, can we close this and wait for it to be fixed upstream? react-scripts-ts@2.12.0 is now up to date with react-scripts@1.0.17, and there hasn't been a change for a while.

@mchenryc
Copy link
Author

Agreed, a divergence for this issue would be silly. Please close.

@wmonk wmonk closed this as completed Jan 15, 2018
@mchenryc
Copy link
Author

@wmonk Just an update - I notice many changes just became available upstream today (https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md)

@wmonk
Copy link
Owner

wmonk commented Jan 15, 2018

@mchenryc lol I waited ages and then just decided to update to 17. Thanks for the heads up, better get to work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants