Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to smithay-client-toolkit 0.17 #225

Closed
colemickens opened this issue Sep 16, 2023 · 9 comments
Closed

update to smithay-client-toolkit 0.17 #225

colemickens opened this issue Sep 16, 2023 · 9 comments

Comments

@colemickens
Copy link

Hi,

My loose understanding is that SCTK 0.17 is a non-trivial update, but I am finding that my various favorite Rust apps using SCTK <0.16 do not work in newer Wayland compositors like sway-tip, Plasma 6, etc.

Hence, this request, that oculante be updated to SCTK 0.17, directly or maybe via sctk-adwaita, from skimming the Cargo.lock.

<3 🙏 Thank you for Oculante! I hope to get back to using it 😢

@colemickens
Copy link
Author

That should say "using SCTK <=0.16", though its unclear if that's specifically because of the version or because 0.17 provokes other changes that cause the issue to go away.

@woelper
Copy link
Owner

woelper commented Sep 16, 2023

Thanks for the kind words and the request!

I am totally unaware of this, sorry. I am still a non-wayland guy (I know...) so I don't run into these issues early.

Can you help me understand a bit how this ties together?

You are using a newer Wayland compositor like Plasma 6, and in these SCTK 0.17 is mandatory?

My issue is that I am not directly able to influence sub-dependencies. I can drill down a bit and see if I can update something that would cause SCTK to be updated though, or you could make the maintainers of a package such as winit aware of this issue for example.

There was an old issue related to wayland:
#24

I'd be interested to see if WINIT_UNIX_BACKEND=x11 ./oculante_linux from a terminal changes anything.

@colemickens
Copy link
Author

Using the X11 backend does work, but is a suboptimal solution IMO. It winds up being blurry since I have sway set to >1 scale.

And yes, I do see that winit uses sctk-adwaita, which in turn uses sctk. I'll have to dig in a bit more to determine what needs to be upgraded. I understand that sctk-0.17 is a big-ish change, and it looks like the SCTK folks might cut a 0.16.1 that might workaround this issue without requiring the full upgrade to 0.17.

And indeed, a number of other apps use winit, so it needs to be fixed there.

I guess probably not much to do here for oculante until sctk-adwaita/winit are updated appropriately.

@colemickens
Copy link
Author

Weird, I'm tired but it seems like you're using a new enough notan, but Oculante's Cargo.lock lists an older sctk-adwaita than I'd expect from looking through notan/winit/sctk-adwaita repos....

@colemickens
Copy link
Author

Oh, I see it now.

winit's bump to sctk 0.17 is unreleased.

so, hopefully they have a release sometime :)

@woelper
Copy link
Owner

woelper commented Sep 18, 2023

Cool, thanks for looking it up in depth. We can leave this open until winit updates, and I can do a release as soon as that happens!

@colemickens
Copy link
Author

Hi @woelper, I have an update! I asked about this in #sway and some smithay devs did a thing.

In short cargo update -p smithay-client-toolkit should pull in a 0.16.1 bugfix release that resolves this issue while the ecosystem waits for the new winit release.

If you could bump that dep and publish a release, that would be dope. 🙂

@woelper
Copy link
Owner

woelper commented Sep 20, 2023

Aye! You got it!

Updating smithay-client-toolkit v0.16.0 -> v0.16.1

@colemickens
Copy link
Author

Thanks for the speediness, hopefully in nixpkgs soon: NixOS/nixpkgs#256343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants