response body is compressed in the retry function I provided

[stefanluptak]

I am doing this

Req.request(base_request(), url: "some url", method: :get)

defp base_request do
  Req.new(retry: &maybe_retry/2, retry_delay: &retry_delay/1, max_retries: 10)
end

and inside my maybe_retry/2 function, when I try to access the response.body, the content is compressed.

After I do this below, it works.

defp maybe_retry(request, %Req.Response{status: 403} = response) do
  {_request, %Req.Response{body: decompressed_body}} = Req.Steps.decompress_body({request, response})

  decoded_body = Jason.decode!(decompressed_body)

  match?(%{"message" => "You have exceeded a secondary rate limit" <> _}, decoded_body)
end

I assumed that the body will be already decompressed as it is in the result of the Req.new() call. Am I mistaken or is this a bug?

[wojtekmach]

The reason it works like this is retry is the very first response step, https://github.com/wojtekmach/req/blob/v0.5.6/lib/req/steps.ex#L85, so it happens before we decompress and decode. I'll need to think some more if we can change the order.

[stefanluptak]

I think just mentioning this in the docs could be enough.