Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help me testing the next release! #102

Closed
wojtekmaj opened this issue Aug 14, 2018 · 9 comments
Closed

Please help me testing the next release! #102

wojtekmaj opened this issue Aug 14, 2018 · 9 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@wojtekmaj
Copy link
Owner

wojtekmaj commented Aug 14, 2018

Hi!
Upcoming React-Calendar v2.17.0 will introduce several improvements, most importantly support for Arabic and Hebrew calendar.

If you are a person coming from any country using locale listed below (mostly: Israel, Brazil, Middle-eastern countries, South American countries), please kindly test the newest release, if the calendar with your locale looks right to you.

You can comment with your feedback below and/or use 👍 👎 reactions. Thank you!

Current pre-release has version number 2.17.0-beta and is published on npm/yarn under next tag. If you don't have a project to experiment on, you can test how the calendar would look like on my test suite:

http://projects.wojtekmaj.pl/react-calendar/test

The following locales will have US-style calendar applied (Sunday first, Sat-Sun weekend):

  • es-AR
  • es-BO
  • es-CL
  • es-CO
  • es-CR
  • es-DO
  • es-EC
  • es-GT
  • es-HN
  • es-MX
  • es-NI
  • es-PA
  • es-PE
  • es-PR
  • es-SV
  • es-VE
  • pt-BR

The following locales will have Arabic style calendar applied (Saturday first, Fri-Sat weekend):

  • ar
  • ar-AE
  • ar-BH
  • ar-DZ
  • ar-EG
  • ar-IQ
  • ar-JO
  • ar-KW
  • ar-LY
  • ar-OM
  • ar-QA
  • ar-SA
  • ar-SD
  • ar-SY
  • ar-YE
  • dv
  • dv-MV
  • ps
  • ps-AR

The following locales will have Hebrew calendar applied (Sunday first, Fri-Sat weekend):

  • he
  • he-IL
@wojtekmaj wojtekmaj added the help wanted Extra attention is needed label Aug 14, 2018
@itayronen
Copy link

Tested "he-IL" and it worked 👍

In our project, we are using react-date-picker that uses this package.
We will wait for the update to get there.

Thank you :)

@wojtekmaj
Copy link
Owner Author

@itayronen Thank you for your input. It won't be long until the update gets to react-date-picker, as I'm the author of them both :) I have issues displaying the calendar properly for Brazilian Portugese on older iPhones, but once that gets resolved, which I assume will happen today, I can go forward with the release.

@rgaino
Copy link

rgaino commented Aug 15, 2018

Hi @wojtekmaj , I am just starting to use the calendar today, literally just ran npm install, but my app is in Brazilian Portuguese so if you need anything let me know please.

@wojtekmaj
Copy link
Owner Author

wojtekmaj commented Aug 15, 2018

Hey @rgaino, basically any of your device that has Brazilian Portugese set as the main language should show the calendar in Portugese and also show Sunday as the first day of the week.

If anything's wrong, I'd appreciate if you could open this link on the same device & browser you have issues with, and copy & paste the results here.

You can pass locale prop to React-Calendar to force it to specific locale, but what I'm really interested in is this auto detection system.

@rgaino
Copy link

rgaino commented Aug 15, 2018

@wojtekmaj what do you consider an older iPhone? The oldest I have access to is a 6s.

@wojtekmaj
Copy link
Owner Author

Hmmm, not sure. I think 6s would do. I got this screenshot from my friend from Brazil and it doesn't look like the proper calendar layout kicked in.

received_268579777076930

@rgaino
Copy link

rgaino commented Aug 16, 2018

What is wrong with it? In Brazil the first day of the week is actually Monday, it's actually a norm from the Brazilian Association of Technical Norms (ABNT). But it's not uncommon at all to see calendars with Sunday as first week, people are really used to both. But officially, this one looks good to me.

@wojtekmaj
Copy link
Owner Author

Ah! Okay, thank you for the insight. I guess nothing stops us from a release now :)

@wojtekmaj wojtekmaj added this to the 2.17.0 milestone Aug 18, 2018
@hlolli

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants