-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please help me testing the next release! #102
Comments
Tested "he-IL" and it worked 👍 In our project, we are using react-date-picker that uses this package. Thank you :) |
@itayronen Thank you for your input. It won't be long until the update gets to react-date-picker, as I'm the author of them both :) I have issues displaying the calendar properly for Brazilian Portugese on older iPhones, but once that gets resolved, which I assume will happen today, I can go forward with the release. |
Hi @wojtekmaj , I am just starting to use the calendar today, literally just ran npm install, but my app is in Brazilian Portuguese so if you need anything let me know please. |
Hey @rgaino, basically any of your device that has Brazilian Portugese set as the main language should show the calendar in Portugese and also show Sunday as the first day of the week. If anything's wrong, I'd appreciate if you could open this link on the same device & browser you have issues with, and copy & paste the results here. You can pass |
@wojtekmaj what do you consider an older iPhone? The oldest I have access to is a 6s. |
What is wrong with it? In Brazil the first day of the week is actually Monday, it's actually a norm from the Brazilian Association of Technical Norms (ABNT). But it's not uncommon at all to see calendars with Sunday as first week, people are really used to both. But officially, this one looks good to me. |
Ah! Okay, thank you for the insight. I guess nothing stops us from a release now :) |
Hi!
Upcoming React-Calendar v2.17.0 will introduce several improvements, most importantly support for Arabic and Hebrew calendar.
If you are a person coming from any country using locale listed below (mostly: Israel, Brazil, Middle-eastern countries, South American countries), please kindly test the newest release, if the calendar with your
locale
looks right to you.You can comment with your feedback below and/or use 👍 👎 reactions. Thank you!
Current pre-release has version number
2.17.0-beta
and is published on npm/yarn undernext
tag. If you don't have a project to experiment on, you can test how the calendar would look like on my test suite:http://projects.wojtekmaj.pl/react-calendar/test
The following locales will have US-style calendar applied (Sunday first, Sat-Sun weekend):
The following locales will have Arabic style calendar applied (Saturday first, Fri-Sat weekend):
The following locales will have Hebrew calendar applied (Sunday first, Fri-Sat weekend):
The text was updated successfully, but these errors were encountered: