Key generation example for Keyed Hash #245

dgarske · 2022-09-28T20:50:35Z

ZD 14876

haydenroche5 · 2022-09-29T21:28:10Z

examples/keygen/keygen.c

@@ -178,6 +179,10 @@ int TPM2_Keygen_Example(void* userCtx, int argc, char *argv[])
            alg = TPM_ALG_SYMCIPHER;
            bAIK = 0;
        }
+        if (XSTRNCMP(argv[argc-1], "-keyedhash", 10) == 0) {


XSTRNCMP unnecessary. argv guaranteed to be null-terminated strings. Use XSTRCMP.

haydenroche5 · 2022-09-29T21:28:53Z

examples/keygen/keygen.c

@@ -300,6 +306,11 @@ int TPM2_Keygen_Example(void* userCtx, int argc, char *argv[])
            rc = wolfTPM2_GetKeyTemplate_Symmetric(&publicTemplate, keyBits,
                    algSym, YES, YES);
        }
+        else if (alg == TPM_ALG_KEYEDHASH) {
+            printf("Keyed Hash template\n");
+                rc = wolfTPM2_GetKeyTemplate_KeyedHash(&publicTemplate,


Looks like this is indented one level too far.

…ygen example whitespace alignment.

Key generation example for Keyed Hash. ZD 14876.

14a4b00

dgarske assigned dgarske and haydenroche5 and unassigned dgarske Sep 28, 2022

dgarske requested a review from haydenroche5 September 29, 2022 18:01

haydenroche5 suggested changes Sep 29, 2022

View reviewed changes

haydenroche5 assigned dgarske and unassigned haydenroche5 Sep 29, 2022

Use strcmp since argv is guaranteed to be NULL terminated. Fix ke…

d491437

…ygen example whitespace alignment.

dgarske requested a review from haydenroche5 October 4, 2022 18:44

dgarske assigned haydenroche5 and unassigned dgarske Oct 4, 2022

haydenroche5 approved these changes Oct 4, 2022

View reviewed changes

haydenroche5 merged commit 11416ff into wolfSSL:master Oct 4, 2022

dgarske deleted the keyedhash branch October 4, 2022 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key generation example for Keyed Hash #245

Key generation example for Keyed Hash #245

dgarske commented Sep 28, 2022

haydenroche5 Sep 29, 2022

haydenroche5 Sep 29, 2022

Key generation example for Keyed Hash #245

Key generation example for Keyed Hash #245

Conversation

dgarske commented Sep 28, 2022

haydenroche5 Sep 29, 2022

Choose a reason for hiding this comment

haydenroche5 Sep 29, 2022

Choose a reason for hiding this comment