Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ST33 support for pre-provisioned device identity key and certificate #336

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Added ST33 support for pre-provisioned device identity key and certificate #336

merged 8 commits into from
Apr 1, 2024

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Mar 20, 2024 •
edited
Loading

  • Add example for using TPM pre-provisioned device identity to TLS client example.
  • Add support for pre-provisioned TPM using the "TPM 2.0 Keys for Device Identity and Attestation" specification. Build macro: WOLFTPM_MFG_IDENTITY.
  • Added ST33 command for getting product info (serial number)
  • Added benchmarks for new ST33KTPM2XI2C.
  • Fixed ST33 vendor command to enable command codes (TPM2_SetCommandSet). It requires platform auth to be set.
  • Fixed 0x1XX error code parsing.

@dgarske dgarske marked this pull request as ready for review March 20, 2024 21:24
@dgarske
ST33 Vendor command for getting product info.
c4880be
@dgarske
Add support for pre-provisioned TPM using the "TPM 2.0 Keys for Devic…
63bb85a 
…e Identity and Attestation" specification. Build macro: `WOLFTPM_MFG_IDENTITY`.
@dgarske
Add example for using TPM pre-provisioned device identity to TLS clie…
551d7da 
…nt example.
@dgarske
Fix for ST33 vendor command to enable command codes (TPM2_SetCommandS…
f983525 
…et). It requires platform auth to be set. Add benchmarks for new ST33KTPM2XI2C. Fix 0x1XX error code parsing.
@philljj
Copy link
Contributor

philljj commented Mar 24, 2024

Can confirm this fixes unit, bench, and wrap. Will test tls_client and the rest next.

philljj
philljj requested changes Mar 26, 2024
View reviewed changes
src/tpm2_wrap.c Show resolved Hide resolved
@philljj philljj self-requested a review March 26, 2024 17:23
philljj
philljj approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@philljj philljj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested WOLFTPM_MFG_IDENTITY on hardware, and reading pre-provisioned cert/key works with TLS. Wrap, native_test, unit, and bench all work.

@dgarske
Copy link
Contributor Author

dgarske commented Apr 1, 2024

Looks good to me. Tested WOLFTPM_MFG_IDENTITY on hardware, and reading pre-provisioned cert/key works with TLS. Wrap, native_test, unit, and bench all work.

Great, I also reviewed your fixes. Looks good. Please merge.

@dgarske dgarske removed their assignment Apr 1, 2024
@philljj philljj merged commit 2cde410 into wolfSSL:master Apr 1, 2024
3 checks passed
@dgarske dgarske deleted the st33_getprodinfo branch April 1, 2024 19:29
dgarske added a commit to dgarske/wolfTPM that referenced this pull request Sep 13, 2024
@dgarske
Proper fix for the RC_WARN error codes. Broken in commit f983525 (PR w…
d7f1e48 
…olfSSL#336). ZD18641
@dgarske dgarske mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philljj philljj philljj approved these changes

Assignees

@philljj philljj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarske @philljj