Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added private key id/label support - improve PK callback public key use #4921

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Added private key id/label support - improve PK callback public key use #4921

merged 1 commit into from
Mar 18, 2022

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Mar 3, 2022 •
edited
Loading

Description

  • Improve logic around private key id/label.
  • Adds WOLF_PRIVATE_KEY_ID.
  • Improve PK callbacks to allow using a public key with wolfSSL_CTX_use_PrivateKey_* and wolfSSL_use_PrivateKey_* API's.

ZD13791

Testing

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Mar 3, 2022
@SparkiDev
Copy link
Contributor

Still see WOLF_CRYPTO_CB being checked in ssl.c.
Do you want to use WOLF_PRIVATE_KEY_ID instead around:
wolfSSL_CTX_check_private_key(), wolfSSL_check_private_key(), wolfSSL_d2i_PrivateKey_id(), wolfSSL_use_PriavetKey_id(), wolfSSL_use_PrivateKey_Id(), wolfSSL_use_PrivateKey_label()?

@dgarske dgarske force-pushed the private_keyid branch 2 times, most recently from a571d6c to e0f36f9 Compare March 4, 2022 17:45
@dgarske dgarske requested a review from SparkiDev March 4, 2022 20:12
@dgarske dgarske force-pushed the private_keyid branch 2 times, most recently from ecac970 to 97e436e Compare March 4, 2022 23:00
@dgarske dgarske force-pushed the private_keyid branch 2 times, most recently from c84eb92 to 68253ef Compare March 9, 2022 18:37
SparkiDev
SparkiDev reviewed Mar 9, 2022
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
@dgarske dgarske changed the title Improve logic around private key id/label KCAPI fixes and added private key id/label support Mar 10, 2022
@dgarske dgarske force-pushed the private_keyid branch 6 times, most recently from 118f146 to 12d63ec Compare March 15, 2022 21:48
@dgarske dgarske changed the title KCAPI fixes and added private key id/label support Added private key id/label support - improve PK callback public key use Mar 17, 2022
@dgarske dgarske requested a review from SparkiDev March 17, 2022 23:17
@dgarske dgarske assigned SparkiDev and unassigned dgarske Mar 17, 2022
@SparkiDev SparkiDev merged commit f117308 into wolfSSL:master Mar 18, 2022
@dgarske dgarske deleted the private_keyid branch March 18, 2022 18:55
@dgarske dgarske mentioned this pull request Jun 16, 2022
Merged
@dgarske dgarske mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SparkiDev SparkiDev SparkiDev approved these changes

Assignees

@SparkiDev SparkiDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarske @SparkiDev