feat(zed): pending-upstream-fix for GHSA-4grx-2x9w-596c, GHSA-c38w-74… #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhring
reviewed
Aug 26, 2024
| - timestamp: 2024-08-21T21:48:03Z | ||
| type: pending-upstream-fix | ||
| data: | ||
| note: There is not currently a fixed version of the rsa crate. Currently, information about private keys is leaked via a side-channel timing attack, but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm. So, we must wait for this implementation to be adopted by the rsa crate maintainers. |
There was a problem hiding this comment.
but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm
could we include a link where someone could check in to see the current status of this if they wanted? Maybe to RustCrypto/RSA#19 ?
Comment on lines
+131
to
+134
| - timestamp: 2024-08-21T21:48:03Z | ||
| type: pending-upstream-fix | ||
| data: | ||
| note: There is not currently a fixed version of the rsa crate. Currently, information about private keys is leaked via a side-channel timing attack, but work is underway to migrate to a fully constant-time implementation of the cryptography algorithm. So, we must wait for this implementation to be adopted by the rsa crate maintainers. |
There was a problem hiding this comment.
Is this whole advisory a duplicate of the CGA-g8r9-vv23-f4jf? Like because there's a duplicate GHSA? If so can we fix this in GHSA so we don't carry the duplicate in our data too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pg-36hr