Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix todo action not grabbing title from first line. #5

Open
nerrad opened this issue Jun 16, 2020 · 2 comments
Open

Fix todo action not grabbing title from first line. #5

nerrad opened this issue Jun 16, 2020 · 2 comments
Labels
type: bug Something isn't working

Comments

@nerrad
Copy link
Collaborator

nerrad commented Jun 16, 2020

For examples, see this pull.

The todo action is pulling titles from the body of the todo rather than the title.

@nerrad nerrad added the type: bug Something isn't working label Jun 16, 2020
@nerrad
Copy link
Collaborator Author

nerrad commented Jun 16, 2020

From testing in the linked pull, it looks like this may be due to detection around sentence stops.

@mikejolley
Copy link
Member

Coming across this in the PR woocommerce/woocommerce-blocks#4268

The title should be the first line, but it's using the longer description. A possible side effect of this is that the duplicate checking code (https://github.com/woocommerce/automations/blob/trunk/lib/automations/todos/utils/check-for-duplicate-issue.js#L20) fails and recreates the same todo on push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants