Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes initial cards as part of refactoring #2585

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Removes initial cards as part of refactoring #2585

merged 2 commits into from
Sep 9, 2024

Conversation

dsawardekar
Copy link
Collaborator

Changes proposed in this Pull Request:

This PR removes the cards that are being reworked from setup-accounts.

Closes #2565

Screenshots:

image

Detailed test instructions:

  1. Reset your local, and start the onboarding flow
  2. You should not see the Google Ads and MC
  3. You should see the disclaimer at its new position

@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Sep 5, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/2458-consolidate-google-account-cards@1030b8d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                               @@
##             feature/2458-consolidate-google-account-cards   #2585   +/-   ##
===============================================================================
  Coverage                                                 ?   63.8%           
===============================================================================
  Files                                                    ?     327           
  Lines                                                    ?    5090           
  Branches                                                 ?    1232           
===============================================================================
  Hits                                                     ?    3248           
  Misses                                                   ?    1674           
  Partials                                                 ?     168
Flag Coverage Δ
js-unit-tests 63.8% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dsawardekar dsawardekar marked this pull request as ready for review September 5, 2024 09:52
@joemcgill joemcgill linked an issue Sep 5, 2024 that may be closed by this pull request
Onboarding: Remove Google MC and Google Ads Cards #2565
Open
5 tasks
joemcgill
joemcgill approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one non-blocking review comment, which we can clarify with @eason9487. Otherwise, I think this looks good. Thanks @dsawardekar!

js/src/setup-mc/setup-stepper/setup-accounts/index.js
</StepContentFooter>
<Section
className="gla-google-mc-account-section"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this classname should probably be changed here and in the relevant styles here, but it's also likely that this text will end up needing to be moved somewhere else before #2509 is completed, so I don't see that as a blocker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that renaming would be more appropriate.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Added a note in the tracking ticket to remind us to come back to this.

@ankitguptaindia
Copy link
Member

QA/Test Report- ✅

Test Results -

Google Ads and MC are no longer appearing on the onboarding screen.

Screenshot 2024-09-06 at 6 38 09 PM

eason9487
eason9487 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It works as expected.

js/src/setup-mc/setup-stepper/setup-accounts/index.js
</StepContentFooter>
<Section
className="gla-google-mc-account-section"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that renaming would be more appropriate.

@eason9487 eason9487 added changelog: none Skip changelog entry for this PR and removed changelog: update Big changes to something that wasn't broken. labels Sep 9, 2024
@joemcgill joemcgill mentioned this pull request Sep 9, 2024
Open
@joemcgill joemcgill merged commit 465c090 into feature/2458-consolidate-google-account-cards Sep 9, 2024
7 checks passed
@joemcgill joemcgill deleted the update/2565-remove-google-mc-and-accounts-cards branch September 9, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcgill joemcgill joemcgill approved these changes

@eason9487 eason9487 eason9487 approved these changes

Assignees
No one assigned
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onboarding: Remove Google MC and Google Ads Cards
4 participants
@dsawardekar @ankitguptaindia @joemcgill @eason9487