Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booked Dates Show as Available #349

Open
2 tasks
ChrissiePollock opened this issue Jun 17, 2023 · 3 comments
Open
2 tasks

Booked Dates Show as Available #349

ChrissiePollock opened this issue Jun 17, 2023 · 3 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@ChrissiePollock
Copy link

The Accommodation product is booked out, but the availability calendar shows it available.

Affected ticket(s)

#6318187-zd

What I expected

Availability would only show dates that are truly available. Not booked dates.

What happened instead

Booked dates show as available.

Steps to reproduce the issue

Set up a site with only the following active:

WooCommerce, WooCommerce Bookings, WooCommerce Accommodation Bookings and WooCommerce Bookings Availability active + Twenty Three theme.

Create a Bookable product
Set an availability calendar on a post or page.

Note that even when a product is booked, the availability page shows it as available. Clicking "Select Options" takes you to the booking page, which shows the dates as not available.

Booked Product:

confirmed

Availability page to Booking page screencast from my test site:

Screen.Recording.2023-06-17.at.12.41.32.PM.mov

One thought is that this is caused by the Bookings slots controller not being able to account for the night duration_unit and partially booked days which Accommodation Bookings adds to the plugin.


  • Issue assigned to next milestone.
  • Issue assigned a priority (will be assessed by maintainers).
@ChrissiePollock ChrissiePollock added the type: bug The issue is a confirmed bug. label Jun 17, 2023
@nicdwilson
Copy link

Booking slots controller duration unit handling is hardcoded here and does not account for the night unit added by Accommodation Bookings.

Products without resources do not reflect bookings on the calendar, while products with resources reflect correct availability but show it by the hour, and not by the night.

@vikrampm1 vikrampm1 added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label Jun 20, 2023
@fetenlakhal
Copy link

@nicdwilson I saw the issue here: 6620198-zd-a8c

Is it expected that half of the day isn't showing as booked as it previously did: 0mlYNP.png

I think this fix changed things: #303

@nicdwilson
Copy link

Hi @fetenlakhal I believe this issue refers to the Bookings Availability Calendar, which depends on API output from bookings itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants