Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String error in cart: From %s per night #350

Open
dixitalmedia opened this issue Jun 22, 2023 · 2 comments
Open

String error in cart: From %s per night #350

dixitalmedia opened this issue Jun 22, 2023 · 2 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@dixitalmedia
Copy link

Hi

When opening cart we see a string which does not make sense.
If price per night is 50 € and we book 3 nights, total price is 150 € but it's shown "From 150 € per night". It just should be "150 € or 150 € per 3 nights"

Captura de pantalla 2023-06-22 a las 11 05 39

Captura de pantalla 2023-06-22 a las 11 07 00

Thanks
@vikrampm1 vikrampm1 added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug. labels Jun 22, 2023
@dixitalmedia
Copy link
Author

Concerning this issue, @vikrampm1 what do you think would be better for Quantity column ?
I'm thinking on hiding it with CSS because it's empty, otherwise it could show "1" or "n" depending of Price column.
I mean, if Price shows "45 €" then Quantity could show "3", but if Price shows "135 €" then Quantity should be "1".
Both are good options.

@vikrampm1
Copy link
Contributor

Looping @jeffpaul for the suggestion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dixitalmedia @vikrampm1