Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Gutenberg SASS Variables: Adopt Base Styles package #3120

Closed
psealock opened this issue Oct 28, 2019 · 1 comment · Fixed by #3292
Closed

Gutenberg SASS Variables: Adopt Base Styles package #3120

psealock opened this issue Oct 28, 2019 · 1 comment · Fixed by #3292
Labels
focus: performance The issue/PR is related to performance. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. tool: monorepo infrastructure

Comments

@psealock
Copy link
Collaborator

WordPress/gutenberg#17883 Creates a Base Styles package to expose SASS variables. Until now, we have had to copy/paste these into our repo so that postCSS processing could apply Woo themes to Gutenberg SASS files.

woocommerce-admin/client/stylesheets/abstracts/_variables.scss

Line 25 in b15dfac

// Gutenberg variables. These are temporary until Gutenberg's variables are exposed.

Now that those variables are exposed, we should use them as an import.
@psealock psealock added tool: monorepo infrastructure focus: performance The issue/PR is related to performance. [estimate] 1 priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Oct 28, 2019
@simison
Copy link

simison commented Nov 21, 2019 •
edited
Loading

You could prolly replace those $muriel- variables with $studio- variables from https://github.com/Automattic/color-studio, too?

@psealock psealock mentioned this issue Nov 21, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
focus: performance The issue/PR is related to performance. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. tool: monorepo infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Component styles: Explicitly import from Gutenberg woocommerce/woocommerce-admin
2 participants
@simison @psealock