Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove fix to load our stylesheets after editor CSS. See ... #3225

Closed
github-actions bot opened this issue Oct 1, 2020 · 7 comments · Fixed by #4097
Closed

Remove fix to load our stylesheets after editor CSS. See ... #3225

github-actions bot opened this issue Oct 1, 2020 · 7 comments · Fixed by #4097
Assignees
@Aljullu
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2020

Remove fix to load our stylesheets after editor CSS. See #3068 for the rationale of this fix. It should be no longer github.com/WordPress/gutenberg/issues/20797).

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e07de12ed23db91cd977be4423132f3151573d87/src/Assets.php#L39-L51

🚀 This issue was generated by the automations bot based on a todo comment in e07de12 when #3219 was merged. cc @Aljullu
@Aljullu Aljullu changed the title Remove fix to load our stylesheets after editor CSS. See ... Remove fix to load our stylesheets after editor CSS. Oct 1, 2020
@Aljullu Aljullu changed the title Remove fix to load our stylesheets after editor CSS. Remove fix to load our stylesheets after editor CSS Oct 1, 2020
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 1, 2020

🚀 Please do not change this issue title! The todo action uses it to prevent duplicate issues from being opened. If you think this is an error, please open an issue!

1 similar comment
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 1, 2020

🚀 Please do not change this issue title! The todo action uses it to prevent duplicate issues from being opened. If you think this is an error, please open an issue!

@github-actions github-actions bot changed the title Remove fix to load our stylesheets after editor CSS Remove fix to load our stylesheets after editor CSS. Oct 1, 2020
@github-actions github-actions bot changed the title Remove fix to load our stylesheets after editor CSS Remove fix to load our stylesheets after editor CSS. See ... Oct 1, 2020
@nerrad nerrad added type: enhancement The issue is a request for an enhancement. type: wp dependency labels Oct 1, 2020
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 11, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 15, 2020
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 14, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 18, 2021
@nerrad
Copy link
Contributor

nerrad commented Apr 21, 2021

Is this still needed @Aljullu - I think we implemented an alternate way of handling this recently?

@Aljullu
Copy link
Contributor

Aljullu commented Apr 22, 2021

In #3898 we refactored this code, but the work-around to load our stylesheets after editor CSS is still there. So I think we should keep this issue open to keep track of it.

The interesting thing is that I tested removing the work-around and I was unable to reproduce #3068 anymore (tested with WP 5.5, 5.7 and latest Gutenberg). I'm not sure what changed since the work-around was implemented, but I think it might be safe to remove it now. I will take a look tomorrow.

@Aljullu Aljullu self-assigned this Apr 22, 2021
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 22, 2021
@Aljullu Aljullu mentioned this issue Apr 23, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove work-around to load our stylesheets after wp-edit-post woocommerce/woocommerce-blocks
2 participants
@nerrad @Aljullu