Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Order Shipping Packages Fill Memory Leak #4047

Closed
mikejolley opened this issue Apr 8, 2021 · 3 comments
Closed

Order Shipping Packages Fill Memory Leak #4047

mikejolley opened this issue Apr 8, 2021 · 3 comments
Assignees
@mikejolley
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. status: awaiting upstream Fix has been made upstream in a dependency. type: bug The issue/PR concerns a confirmed bug.

Comments

@mikejolley
Copy link
Member

Reported here: #4025 (review)

https://user-images.githubusercontent.com/1429108/113930901-dac7b180-97bf-11eb-9338-882f6eb2af98.png

Reproducible on trunk. For me, I just needed to change the country select box during checkout to see the error logged to console.
@mikejolley mikejolley added the type: bug The issue/PR concerns a confirmed bug. label Apr 8, 2021
@mikejolley mikejolley mentioned this issue Apr 8, 2021
Merged
@mikejolley mikejolley self-assigned this Apr 8, 2021
@mikejolley mikejolley mentioned this issue Apr 9, 2021
Merged
2 tasks
@mikejolley
Copy link
Member Author

@nerrad I've raised a fix upstream: WordPress/gutenberg#30667

What should we do with this issue in the meantime?

@nerrad
Copy link
Contributor

nerrad commented Apr 9, 2021

Let's leave it open but add back to the tier one backlog? This will keep it surfacing for review when the fix in GB eventually gets into a release?

@mikejolley mikejolley added status: awaiting upstream Fix has been made upstream in a dependency. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Apr 9, 2021
@mikejolley
Copy link
Member Author

This fix has been merged upsteam 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. status: awaiting upstream Fix has been made upstream in a dependency. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejolley @nerrad