Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Editor: Cart and Checkout inner blocks have missing translations in the inspector #6244

Closed
ralucaStan opened this issue Apr 13, 2022 · 1 comment · Fixed by #6737
Closed

Editor: Cart and Checkout inner blocks have missing translations in the inspector #6244

ralucaStan opened this issue Apr 13, 2022 · 1 comment · Fixed by #6737
Assignees
@tarhi-saad
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: i18n The issue/PR is related to internationalization. status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@ralucaStan
Copy link
Contributor

Describe the bug

Cart and Checkout inner blocks have missing translations in the inspector in the editor.

To reproduce

  1. Go to your website and install a different language (I used Romanian)
  2. Go to the editor to the Cart block page
  3. Select the Subtotal inner block
  4. Notice that the Inner block is translated, but the inspector title is not
  5. Try the same with the Shipping block
  6. Test the Checkout block as well.

Expected behavior

The texts for innerblocks should be translated in the inspector as well.

Screenshots

Screenshot 2022-04-13 at 12 09 08

Notice how not all the content is translated. The Shipping calculator is translated, but the title is not.

Screenshot 2022-04-13 at 12 07 09
@ralucaStan ralucaStan added type: bug The issue/PR concerns a confirmed bug. focus: i18n The issue/PR is related to internationalization. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Apr 13, 2022
@ralucaStan ralucaStan mentioned this issue Apr 13, 2022
Merged
5 tasks
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 13, 2022
@ralucaStan ralucaStan removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 13, 2022
@Marc-pi Marc-pi mentioned this issue Jul 8, 2022
Closed
@tarhi-saad tarhi-saad self-assigned this Jul 19, 2022
@ralucaStan ralucaStan added the status: blocker Used on issues or pulls that block work from being released. label Jul 20, 2022
@tarhi-saad tarhi-saad mentioned this issue Jul 29, 2022
Merged
16 tasks
@Aljullu Aljullu mentioned this issue Jan 26, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tarhi-saad tarhi-saad

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: i18n The issue/PR is related to internationalization. status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing translations in inspector woocommerce/woocommerce-blocks
2 participants
@ralucaStan @tarhi-saad