This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
AvaTax causes a fatal error when renewing subscriptions #8473
Labels
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
type: bug
The issue/PR concerns a confirmed bug.
Comments
5975104-zen |
32138782-hc |
37663405-hc
|
5967453-zen |
36019744- hc |
We have a callback for the
In the context of a subscription renewal, the session is not set up, and if it were, the chosen shipping method would not be there anyway. We need a way to check what context we're filtering the address in if possible, if it is during a renewal, we should try to derive the shipping method from the order, and if it is from an ordinary checkout, we can continue as normal. |
ralucaStan
added
the
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
label
Feb 22, 2023
7 tasks
Another instance in 40423785-hc |
As seen in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
type: bug
The issue/PR concerns a confirmed bug.
Describe the bug
Reported in p1676641499676679-slack-C01DT6U03HC
There is a fatal error when using AvaTax and WooCommerce 7.4.0 - this was introduced in 5c01299
To reproduce
Steps to reproduce the behavior:
Expected behavior
Subscription renewals should work even if AvaTax is enabled.
Additional context
See https://github.com/woocommerce/woocommerce-blocks/blob/trunk/src/Shipping/ShippingController.php#L292 for the line this error happens on.
Also cc @woocommerce/helix in case you want to take a look - the stack trace can be found in the slack message: p1676641499676679-slack-C01DT6U03HC
The text was updated successfully, but these errors were encountered: