Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

When the Mini cart modal has a border, the close button should not be on top of it #8716

Closed
Tracked by #8556
, #9198
...
albarin opened this issue Mar 13, 2023 · 1 comment · Fixed by #9507
Closed
Tracked by #8556
, #9198
...

When the Mini cart modal has a border, the close button should not be on top of it #8716

albarin opened this issue Mar 13, 2023 · 1 comment · Fixed by #9507
Assignees
@Aljullu
Labels
block: mini-cart Issues related to the Mini-Cart block. Contributor Day - H1 2023 focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.

Comments

@albarin
Copy link
Contributor

albarin commented Mar 13, 2023

Describe the bug

When the Mini cart sidebar has a border, the close "x" button is on top of it and it does not look good, especially on dark themes.

To reproduce

  1. Enable TT2 theme with Swiss style.
  2. Create a page with the Mini cart block and save it.
  3. Go to the frontend, and click on the Mini cart button to open the sidebar.
  4. See that the "x" button is on top of the border.

Expected behavior

The "x" button should be inside the sidebar content, not on the border.

Screenshots

image
@albarin albarin added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. block: mini-cart Issues related to the Mini-Cart block. labels Mar 13, 2023
@Aljullu Aljullu mentioned this issue Mar 14, 2023
Closed
@kmanijak
Copy link
Contributor

May be addressed in scope of #8606

@Aljullu Aljullu mentioned this issue Mar 21, 2023
Closed
4 tasks
@Aljullu Aljullu mentioned this issue Apr 25, 2023
Closed
@Aljullu Aljullu self-assigned this May 18, 2023
@Aljullu Aljullu mentioned this issue May 18, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
block: mini-cart Issues related to the Mini-Cart block. Contributor Day - H1 2023 focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
Contributor Day - Blocks
Status: Todo
Milestone
No milestone
4 participants
@albarin @Aljullu @tjcafferkey @kmanijak