Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Price block inside the All Products block: shows product selector in the editor #8932

Closed
Aljullu opened this issue Apr 3, 2023 · 2 comments · Fixed by #8980
Closed
Assignees
Labels
block: all products Issues related to the all products block. block-type: product elements Issues related to Product Element blocks. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Apr 3, 2023

This is a recent regression, as I couldn't reproduce in WC core 7.5 without WC Blocks installed.

To reproduce

  1. Create a post or page.
  2. Insert the All Products block.
  3. Edit the layout of the All Products block.
  4. Notice the Product Price inner block shows a product selector.

Expected behavior

The Product Price block inside the All Products block should display the product price, not the product selector.

Screenshots

WC 7.5 WC 7.5 with WC Blocks 9.9
imatge imatge
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: all products Issues related to the all products block. block-type: product elements Issues related to Product Element blocks. labels Apr 3, 2023
@Aljullu
Copy link
Contributor Author

Aljullu commented Apr 3, 2023

@gigitux I think this was introduced in #8609. Considering that we no longer allow inserting the Product Price block without a parent. Do you think we could completely remove the ProductSelector?

@gigitux
Copy link
Contributor

gigitux commented Apr 4, 2023

@gigitux I think this was introduced in #8609. Considering that we no longer allow inserting the Product Price block without a parent. Do you think we could completely remove the ProductSelector?

Thanks for catching this! I agree with you! I will assign this issue to me 💪

@gigitux gigitux self-assigned this Apr 4, 2023
@gigitux gigitux linked a pull request Apr 6, 2023 that will close this issue
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: all products Issues related to the all products block. block-type: product elements Issues related to Product Element blocks. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants