Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Blockified Single Product Template: Modify the default header level for the product title from h2 to h1 #9695

Closed
Tracked by #8054
xristos3490 opened this issue Jun 2, 2023 · 4 comments · Fixed by #9698
Closed
Tracked by #8054

Blockified Single Product Template: Modify the default header level for the product title from h2 to h1 #9695

xristos3490 opened this issue Jun 2, 2023 · 4 comments · Fixed by #9698
Assignees
@gigitux
Labels
focus: template Related to API powering block template functionality in the Site Editor type: enhancement The issue is a request for an enhancement.

Comments

@xristos3490
Copy link
Member

xristos3490 commented Jun 2, 2023 •
edited
Loading

Description

The product title block in the single product template currently utilizes an 'h2' heading level, which seems not semantically accurate. It would be more appropriate to use an h1 level instead.
@xristos3490 xristos3490 added the type: enhancement The issue is a request for an enhancement. label Jun 2, 2023
@Sadaf-A
Copy link

Sadaf-A commented Jun 2, 2023

Greetings @xristos3490, I would love to work on this!

@gigitux gigitux added the focus: template Related to API powering block template functionality in the Site Editor label Jun 2, 2023
@gigitux
Copy link
Contributor

gigitux commented Jun 2, 2023

Hi @xristos3490,
Thanks for opening this issue! Great observation!

@Sadaf-A, thanks for proposing to work on it. It is necessary to update this line adding "level":1. Keep in mind that we have some time constraints since we want to include this change in the next release (next week), so I could open a PR before my EOD if you can't do it.

@gigitux gigitux self-assigned this Jun 2, 2023
@Sadaf-A
Copy link

Sadaf-A commented Jun 2, 2023

@gigitux I'm a beginner so I'm not sure if I can finish it within the given timeframe.
you could open a PR.

@gigitux
Copy link
Contributor

gigitux commented Jun 2, 2023

@Sadaf-A If you want to contribute to WooCommerce Blocks, we have several issues labeled as "good first issue". You can check them here.
For any questions, you can add a comment on the specific issue!

@gigitux gigitux mentioned this issue Jun 2, 2023
Closed
52 tasks
@gigitux gigitux linked a pull request Jun 2, 2023 that will close this issue
Blockified Single Product Template: use h1 for the Product Title #9698
Merged
4 tasks
@gigitux gigitux mentioned this issue Jun 2, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gigitux gigitux

Labels
focus: template Related to API powering block template functionality in the Site Editor type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blockified Single Product Template: use h1 for the Product Title woocommerce/woocommerce-blocks
3 participants
@xristos3490 @gigitux @Sadaf-A