Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Block Directory inclusion explorations (Design & Technical) #975

Closed
nerrad opened this issue Sep 20, 2019 · 10 comments
Closed

Block Directory inclusion explorations (Design & Technical) #975

nerrad opened this issue Sep 20, 2019 · 10 comments

Comments

@nerrad
Copy link
Contributor

nerrad commented Sep 20, 2019

This issue is intended to track explorations (both technical and design) for how WooCommerce blocks will be discovered/used within the pending new WordPress Block Directory coming to Gutenberg.

Related Links:

WP.org related

cc @jwold for reference.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jwold
Copy link

jwold commented Sep 23, 2019

@nerrad my sense is there's value in waiting to see where the work is likely to land from the .org team. We could start playing with things earlier, and share that back to the team with our own insights, but it could mean additional work later. I'm happy to start on this now if we think it's a priority, but would recommend waiting. Thoughts?

cc @pmcpinto

@nerrad
Copy link
Contributor Author

nerrad commented Sep 23, 2019

I'm happy to start on this now if we think it's a priority, but would recommend waiting.

I agree it's still early for any definite plans. I mostly just created this as a tracking issue for explorations/experiments. There's a couple things I think we may want to influence the direction on for what is final in core:

  • Grouping by product (i.e. All Woo blocks etc).
  • Limiting blocks to only be downloaded as part of a group (or communicating dependencies somehow).

So I don't think we need to prioritize building specific interfaces yet, but should experiment here and there with what we'd like to see so it can help influence (hopefully) the end result in core.

Ideally, I think it could be to our benefit to have something ready to launch when this does land in WP core.

@nerrad
Copy link
Contributor Author

nerrad commented Sep 23, 2019

I just noticed Mike added it to the Design/Planning Sprint in Zenhub - might be too early for that? I'll let Pedro weigh in here :)

@jwold
Copy link

jwold commented Sep 23, 2019

Great thoughts! I'm ok with starting earlier if we all agree, but otherwise definitely agree to making sure we're ready when it lands in core.

@pmcpinto
Copy link

Do we already know when the block directory is going to be ready for prime time? I notice that 6.5 already includes an experiment around this (WordPress/gutenberg#17431), but I'm not finding any estimation for when the "final" version is going to be ready.

I think we should wait at least until sprint 25 ends. My biggest concern is how long is going to take us on the technical side to adapt our plugin to this single block paradigm.

This could be a useful exploration for that cool-down period after a 4-6 week cycle we talked about. Btw, I have to draft the post about that to see if we all agree with that approach and we take it from there.

@nerrad
Copy link
Contributor Author

nerrad commented Sep 23, 2019

I think we should wait at least until sprint 25 ends. My biggest concern is how long is going to take us on the technical side to adapt our plugin to this single block paradigm.

Some of the bits and pieces needed to support the new block directory are already implemented in Gutenberg core (namely block.json configs). Since that will help with the refactoring I'm doing anyways for block loading, I can do that part without waiting for the main block directory to land.

For the rest, I agree we can wait until sprint 25 ends. I mostly just wanted to document this issue so it's not forgotten. I can shift away from doing further explorations (except I'll still implement block.json for block loading).

@nerrad
Copy link
Contributor Author

nerrad commented Dec 4, 2019

From this guidelines doc it looks like we won't be able to utilize the Block Directory for discovery of our blocks unless we're willing to split things up into individual "Block Plugins".

@jwold
Copy link

jwold commented Dec 4, 2019

From this guidelines doc it looks like we won't be able to utilize the Block Directory for discovery of our blocks unless we're willing to split things up into individual "Block Plugins".

Thank you for finding that! I wasn't aware of that guidelines restriction. Based on how are individual blocks work now I don't think it'd make sense to split them into individual plugins. So it sounds like we shouldn't go that route.

@nerrad
Copy link
Contributor Author

nerrad commented Dec 4, 2019

Ya the guidelines were fairly recently posted. It definitely changes the relevancy of this issue. I'm going to close it for now - we can create a new issue if we decide down the road there are certain blocks we want to be discoverable via the block directory but for now I think it's a dead horse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants