This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Checkout Field Padding and Spacing #11207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
type: enhancement
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +93 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
mikejolley
force-pushed
the
fix/field-spacing
branch
from
fd21870 to
e090d9f
Compare
|
I've rebased with the other merged styling changes, so this should be good to review. |
nielslange
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. I've successfully tested the changes. Let's ⛴️ this PR.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves field spacing based on the designs in figma. This also fixes autocomplete styles, and implements the correct label color. The designs used px based sizes, but checkout uses relative units. I applied the styles based on a 16px size and then wrapped the units in the
em()mixin so things scale appropriately.Fixes #10889
Why
For a more consistent appearance.
Testing Instructions
Compare to screenshots below.
Screenshots or screencast
These are screenshots from Twenty Twenty Three which uses an 18px base size.
Before:
After:
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog