This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Block Checkout: Add back missing render-checkout-form hook #11554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
type: bug
The issue/PR concerns a confirmed bug.
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
labels
Nov 2, 2023
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
November 2, 2023 14:58
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +147 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
opr
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restores the
experimental__woocommerce_blocks-checkout-render-checkout-form
hook fired when the checkout form is displayed. This is used for analaytics.Part of #11472
Why
This hook was removed by accident in https://github.com/woocommerce/woocommerce-blocks/pull/4745/files
Testing Instructions
Add this code somewhere, for example, main plugin file:
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog