This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update Jetpack WooCommerce Analytics module integration to check for changed template names #11707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
senadir
approved these changes
Nov 9, 2023
opr
removed
the
skip-changelog
nielslange
added a commit
that referenced
this pull request
Nov 13, 2023
* Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Update Jetpack WooCommerce Analytics module integration to check for changed template names (#11707) * Bump versions to 11.4.6 * Add testing notes * Update testing zip * Skip template related E2E tests (#11700) * Empty commit for release pull request * Fix address block invalidations in the editor and address card display in Firefox (#11714) * Add checks to see if getCartData finished before rendering address * Prevent block error due to excessive updates of customValidation * Do not condense address in admin and handle phone field * Add missing showPhoneField for billing --------- Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> * Add changelog in "readme.txt" * Run change version npm script * Add testing notes * Empty commit for release pull request * Add changelog in "readme.txt" * Add version numbers * Ensure that incompatible notices are displayed in Safari. (#11736) * Add the testing docs * Update testing notes title of 11.4.8 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Niels Lange <info@nielslange.de>
|
This is a duplicate, right? |
|
Hi @Lockoloop yep the issue you created (#11750) is fixed by this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There is a PHP Warning when WooCommerce Cart/Checkout templates were not found. The templates are now called page-checkout and page-cart and the code has been updated to look for them.
Why
To prevent the warning
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog