This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Continue validating schema after validating nested properties #11792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
nielslange
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. I've successfully tested the fix and could not spot anything strange in the code. Let's ⛴️ this fix.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
mikejolley
force-pushed
the
fix/extension-schema-validation
branch
from
f0db1e9 to
e6ae687
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#11446 reported than when multiple extensions register data in the Store API, required field validation only runs for the first item in the schema. This PR fixes this behaviour.
Fixes #11446
Why
Multiple extensions may be using Store API at once, so this ensures all validation runs recursively.
Testing Instructions
This requires code, so this should only be tested by developers.
Add this to functions.php or the main plugin file:
This registers 2 additional schemas on the checkout route.
extensions > my-extension-test is not of type object.wp.data.dispatch( 'wc/store/checkout' ).__internalSetExtensionData( 'my-extension-test', { 'my_field': 'test' } );This adds data for the first schema.extensions > my-extension-test-2 is not of type object.. This is what was fixed.wp.data.dispatch( 'wc/store/checkout' ).__internalSetExtensionData( 'my-extension-test-2', { 'my_field': 'test' } );This adds data for the second schema.WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog