This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Preserve shrinkColumns value when switching the layout type of Product Collection #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
14 tasks
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/migration-products-to-product-collection/migration-from-products-to-product-collection.ts
|
kmanijak
changed the title
|
Size Change: -4 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Nov 22, 2023
kmanijak
deleted the
add/preserve-shrink-columns-in-product-collection
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The "Shrink columns to fit" option was not preserved on product Collection when switched from Grid view to Stack view and the opposite.
This PR makes that values preserved.
Additionally, it improves TS typing of related attributes.
Why
Switching view should not revert the "Shrink columns to fit" to false.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog