Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Updates for the abstract block class #2566

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

mikejolley
Copy link
Member

#2399 is a mammoth PR so I'm breaking out some fixes and changes to review separately.

This updates the Abstract Block class to:

  1. Allow the block name to be added via the constructor. I will need this to register Atomic Blocks later on to allow class reuse, otherwise I'd need a class per atomic block.
  2. Fixes a white space issue in the attributes replacement.
  3. Fixes array/object handling - they need converting to JSON before appending to the HTML.

These are under the hood changes for future use, so nothing specific to test against so long as tests pass and no obvious regressions occur.

@mikejolley mikejolley added this to the 2.7.0 milestone May 26, 2020
@mikejolley mikejolley requested a review from a team as a code owner May 26, 2020 17:11
@mikejolley mikejolley self-assigned this May 26, 2020
@mikejolley mikejolley requested review from senadir and removed request for a team May 26, 2020 17:11
@senadir
Copy link
Member

senadir commented May 26, 2020

Providing dynamic block names make sense to me.

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.23 kB 0 B
build/active-filters.js 7.89 kB 0 B
build/all-products-frontend.js 71.8 kB 0 B
build/all-products.js 19.2 kB 0 B
build/all-reviews-legacy.js 10.3 kB 0 B
build/all-reviews.js 10.6 kB 0 B
build/attribute-filter-frontend.js 16.7 kB 0 B
build/attribute-filter.js 11.5 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 775 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.92 kB 0 B
build/cart-frontend.js 113 kB 0 B
build/cart.js 32.3 kB 0 B
build/checkout-frontend.js 129 kB 0 B
build/checkout.js 37.8 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 782 B 0 B
build/editor-legacy-rtl.css 12.5 kB 0 B
build/editor-legacy.css 12.6 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 146 kB 0 B
build/featured-category.js 146 kB 0 B
build/featured-product-legacy.js 9.49 kB 0 B
build/featured-product.js 9.81 kB 0 B
build/handpicked-products-legacy.js 6.88 kB 0 B
build/handpicked-products.js 7.15 kB 0 B
build/panel-style-legacy.js 773 B 0 B
build/panel-style.js 773 B 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 9.97 kB 0 B
build/product-best-sellers-legacy.js 6.96 kB 0 B
build/product-best-sellers.js 7.23 kB 0 B
build/product-categories-legacy.js 3.22 kB 0 B
build/product-categories.js 3.21 kB 0 B
build/product-category-legacy.js 7.88 kB 0 B
build/product-category.js 8.13 kB 0 B
build/product-list-style-legacy.js 775 B 0 B
build/product-new-legacy.js 7.12 kB 0 B
build/product-new.js 7.39 kB 0 B
build/product-on-sale-legacy.js 7.49 kB 0 B
build/product-on-sale.js 7.79 kB 0 B
build/product-search-legacy.js 3.12 kB 0 B
build/product-search.js 3.36 kB 0 B
build/product-tag-legacy.js 6.07 kB 0 B
build/product-tag.js 6.33 kB 0 B
build/product-top-rated-legacy.js 7.09 kB 0 B
build/product-top-rated.js 7.37 kB 0 B
build/products-by-attribute-legacy.js 7.85 kB 0 B
build/products-by-attribute.js 8.11 kB 0 B
build/reviews-by-category-legacy.js 12.3 kB 0 B
build/reviews-by-category.js 12.7 kB 0 B
build/reviews-by-product-legacy.js 13.8 kB 0 B
build/reviews-by-product.js 14.2 kB 0 B
build/reviews-frontend-legacy.js 7.99 kB 0 B
build/reviews-frontend.js 8.81 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 778 B 0 B
build/spinner-style-legacy.js 775 B 0 B
build/spinner-style.js 771 B 0 B
build/style-legacy-rtl.css 5.62 kB 0 B
build/style-legacy.css 5.63 kB 0 B
build/style-rtl.css 16.6 kB 0 B
build/style.css 16.5 kB 0 B
build/vendors-legacy.js 376 kB 0 B
build/vendors-style-legacy-rtl.css 1.65 kB 0 B
build/vendors-style-legacy.css 1.65 kB 0 B
build/vendors-style-legacy.js 105 B 0 B
build/vendors-style-rtl.css 1.65 kB 0 B
build/vendors-style.css 1.65 kB 0 B
build/vendors-style.js 105 B 0 B
build/vendors.js 473 kB 0 B
build/wc-blocks-data.js 7.08 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 1.79 kB 0 B
build/wc-payment-method-cheque.js 794 B 0 B
build/wc-payment-method-paypal.js 830 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B

compressed-size-action

@mikejolley mikejolley merged commit ba0c0de into master May 27, 2020
@mikejolley mikejolley deleted the update/abstract-block-fixes branch May 27, 2020 10:11
@Aljullu Aljullu added the skip-changelog PRs that you don't want to appear in the changelog. label Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog PRs that you don't want to appear in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants