Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Issue #7299 Check for area property before use #7341

Closed
wants to merge 2 commits into from

Conversation

ohfuchs
Copy link

@ohfuchs ohfuchs commented Oct 8, 2022

Added check to prevent notice when there is no template_part area defined.

for example an area property is missing Mini Cart template part

Fixes #7299

@sunyatasattva sunyatasattva self-requested a review October 10, 2022 16:35
Copy link
Contributor

@sunyatasattva sunyatasattva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ohfuchs ! Thank you for the contribution: it looks good! I would ask you however to improve a bit the PR description. You should use the template we offer whenever you open a PR, there are important things such as the testing steps and even the changelog entry that we use while deploying new versions, so these are crucial to us.

On top of that, a good PR description is extremely helpful for historical reasons, as we are many people working on this project and it helps being able to go back on a line of code and see a complete description and reasoning on why it was added.

That would help very much!

@github-actions
Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 19, 2022
@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 21, 2022
@albarin
Copy link
Contributor

albarin commented Feb 16, 2023

Fixed by #8443

@albarin albarin closed this Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice: Undefined property: stdClass::$area in BlockTemplatesController.php
3 participants